Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: Begin implementing super root trace provider #13777

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

ajsutton
Copy link
Contributor

Description

Implements the trace provider for the top half of interop games. Couple of todos still in the code around the data we get from the supervisor but that's tidy up and handling proposals that are past the cross-safe head. Otherwise it seems to work.

I have a spike showing how to hook it all in but it winds up being much easier to integrate it all if you have this trace provider first and know exactly what data it needs.

Tests

Added unit tests.

@ajsutton ajsutton requested review from a team as code owners January 15, 2025 00:27
@ajsutton ajsutton requested review from Inphi and sebastianst January 15, 2025 00:27
@ajsutton ajsutton marked this pull request as draft January 15, 2025 00:27
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 67.77778% with 29 lines in your changes missing coverage. Please review.

Project coverage is 42.86%. Comparing base (6f0d98c) to head (35a1f86).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
op-challenger/game/fault/trace/super/provider.go 76.31% 12 Missing and 6 partials ⚠️
op-service/eth/super_root.go 0.00% 8 Missing ⚠️
op-program/client/interop/types/roots.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13777      +/-   ##
===========================================
- Coverage    47.12%   42.86%   -4.26%     
===========================================
  Files          958      793     -165     
  Lines        79963    70673    -9290     
  Branches       758        0     -758     
===========================================
- Hits         37681    30293    -7388     
+ Misses       39387    37735    -1652     
+ Partials      2895     2645     -250     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-program/client/interop/interop.go 45.36% <100.00%> (+0.80%) ⬆️
op-program/client/interop/types/roots.go 37.50% <40.00%> (+3.21%) ⬆️
op-service/eth/super_root.go 48.83% <0.00%> (-5.01%) ⬇️
op-challenger/game/fault/trace/super/provider.go 76.31% <76.31%> (ø)

... and 174 files with indirect coverage changes

@ajsutton
Copy link
Contributor Author

Should land #13786 before this one as we can then refer to the SuperRootResponse type from the shared package and not introduce a dependency on the op-supervisor code.

@ajsutton ajsutton force-pushed the aj/challenger-superroot-provider branch from 6a7d5e8 to b92eeb5 Compare January 15, 2025 17:19
@ajsutton ajsutton marked this pull request as ready for review January 15, 2025 17:48
@ajsutton ajsutton added this pull request to the merge queue Jan 15, 2025
Merged via the queue into develop with commit 50682ad Jan 15, 2025
43 checks passed
@ajsutton ajsutton deleted the aj/challenger-superroot-provider branch January 15, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants