Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: Define register task for super cannon #13794

Draft
wants to merge 4 commits into
base: aj/challenger-less-clients
Choose a base branch
from

Conversation

ajsutton
Copy link
Contributor

Description

Tracer bullet for defining the registration task for super cannon games. Will need to break into a few different PRs and can't actually create the task until we get #13770 merged and implement a supervisor client.

Builds on #13792

@ajsutton ajsutton force-pushed the aj/challenger-interop-split-adapter branch from ac3e4b9 to c222d88 Compare January 15, 2025 21:29
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 28.97727% with 125 lines in your changes missing coverage. Please review.

Project coverage is 44.36%. Comparing base (c4aba66) to head (f67f771).

Files with missing lines Patch % Lines
...challenger/game/fault/trace/super/split_adapter.go 0.00% 30 Missing ⚠️
op-challenger/game/fault/trace/super/prestate.go 0.00% 17 Missing ⚠️
...-challenger/game/fault/trace/super/super_cannon.go 0.00% 17 Missing ⚠️
op-challenger/game/fault/register.go 0.00% 16 Missing ⚠️
op-challenger/game/fault/register_task.go 0.00% 15 Missing ⚠️
...challenger/game/fault/trace/split/local_context.go 0.00% 15 Missing ⚠️
op-challenger/game/fault/trace/super/provider.go 67.85% 8 Missing and 1 partial ⚠️
...allenger/game/fault/trace/outputs/split_adapter.go 66.66% 3 Missing ⚠️
...lenger/game/fault/trace/outputs/output_alphabet.go 0.00% 1 Missing ⚠️
...lenger/game/fault/trace/outputs/output_asterisc.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                      Coverage Diff                       @@
##           aj/challenger-less-clients   #13794      +/-   ##
==============================================================
+ Coverage                       42.88%   44.36%   +1.48%     
==============================================================
  Files                             793      856      +63     
  Lines                           70741    75630    +4889     
==============================================================
+ Hits                            30338    33556    +3218     
- Misses                          37761    39252    +1491     
- Partials                         2642     2822     +180     
Flag Coverage Δ
cannon-go-tests-32 62.26% <ø> (?)
cannon-go-tests-64 57.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...hallenger/game/fault/contracts/faultdisputegame.go 67.45% <ø> (ø)
...llenger/game/fault/trace/outputs/provider_cache.go 100.00% <100.00%> (ø)
op-challenger/game/fault/trace/super/convert.go 100.00% <100.00%> (ø)
...hallenger/game/fault/trace/super/provider_cache.go 100.00% <100.00%> (ø)
op-challenger/game/fault/trace/utils/local.go 62.50% <100.00%> (ø)
...lenger/game/fault/trace/outputs/output_alphabet.go 0.00% <0.00%> (ø)
...lenger/game/fault/trace/outputs/output_asterisc.go 0.00% <0.00%> (ø)
...allenger/game/fault/trace/outputs/output_cannon.go 0.00% <0.00%> (ø)
...allenger/game/fault/trace/outputs/split_adapter.go 68.42% <66.66%> (-8.94%) ⬇️
op-challenger/game/fault/trace/super/provider.go 73.41% <67.85%> (-2.90%) ⬇️
... and 6 more

... and 69 files with indirect coverage changes

@ajsutton ajsutton force-pushed the aj/challenger-interop-game-type branch from d7b0fe9 to e1f482d Compare January 15, 2025 22:01
@ajsutton ajsutton force-pushed the aj/challenger-interop-split-adapter branch from c222d88 to 607348b Compare January 15, 2025 22:04
Base automatically changed from aj/challenger-interop-game-type to develop January 15, 2025 22:12
@ajsutton ajsutton force-pushed the aj/challenger-interop-split-adapter branch from 607348b to 84c21e4 Compare January 15, 2025 22:13
@ajsutton ajsutton force-pushed the aj/challenger-interop-split-adapter branch from 84c21e4 to f67f771 Compare January 15, 2025 22:43
@ajsutton ajsutton changed the base branch from develop to aj/challenger-less-clients January 15, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant