-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-challenger: Define register task for super cannon #13794
Draft
ajsutton
wants to merge
4
commits into
aj/challenger-less-clients
Choose a base branch
from
aj/challenger-interop-split-adapter
base: aj/challenger-less-clients
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
op-challenger: Define register task for super cannon #13794
ajsutton
wants to merge
4
commits into
aj/challenger-less-clients
from
aj/challenger-interop-split-adapter
+448
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
force-pushed
the
aj/challenger-interop-split-adapter
branch
from
January 15, 2025 21:29
ac3e4b9
to
c222d88
Compare
ajsutton
force-pushed
the
aj/challenger-interop-game-type
branch
from
January 15, 2025 22:01
d7b0fe9
to
e1f482d
Compare
ajsutton
force-pushed
the
aj/challenger-interop-split-adapter
branch
from
January 15, 2025 22:04
c222d88
to
607348b
Compare
ajsutton
force-pushed
the
aj/challenger-interop-split-adapter
branch
from
January 15, 2025 22:13
607348b
to
84c21e4
Compare
Its only used by split adapter and isn't related to the contracts.
ajsutton
force-pushed
the
aj/challenger-interop-split-adapter
branch
from
January 15, 2025 22:43
84c21e4
to
f67f771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tracer bullet for defining the registration task for super cannon games. Will need to break into a few different PRs and can't actually create the task until we get #13770 merged and implement a supervisor client.
Builds on #13792