Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Voltaire erc-4337 bundler integration #298

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sherifahmed990
Copy link

Description

This pr contains shell scripts to run and stop three voltaire bundler docker containers for the 3 default chains in supersim.
Also the script can be modified for fork mode.

@sherifahmed990 sherifahmed990 requested a review from a team as a code owner December 10, 2024 08:46
@hamdiallam hamdiallam enabled auto-merge (squash) December 20, 2024 19:58
@hamdiallam
Copy link
Contributor

tysm @sherifahmed990 !

@Sednaoui
Copy link

Hello @hamdiallam , the PR seems to be blocked by the Unit Tests/go-tests for some reason, even if the content of the RP is in a complete new folder. Do you have a recommendation on how to unblock this?

@fainashalts
Copy link
Collaborator

Hi @Sednaoui can you merge in the latest changes from the main branch? That should trigger the tests to run again and we can see what's going on if it still fails. Thanks so much!

@Sednaoui
Copy link

Hi @Sednaoui can you merge in the latest changes from the main branch? That should trigger the tests to run again and we can see what's going on if it still fails. Thanks so much!

cc @sherifahmed990

auto-merge was automatically disabled January 14, 2025 21:12

Head branch was pushed to by a user without write access

@sherifahmed990
Copy link
Author

Hi @Sednaoui can you merge in the latest changes from the main branch? That should trigger the tests to run again and we can see what's going on if it still fails. Thanks so much!

latest changes merged @fainashalts

@fainashalts
Copy link
Collaborator

Hi @sherifahmed990! Thank you for the update! Looks like we have one test failing, can you take a look? Will be happy to merge this in once everything is passing.

@Sednaoui
Copy link

Thank you for reviewing @fainashalts. Unfortunately the main branch has the same test failing. The fail is not related to this PR.

https://github.com/ethereum-optimism/supersim/runs/35737482822

This PR opens a complete new folder with the ERC-4337 Bundler addition, so it's not related to the go unit-tests that are failling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants