slash when validator has deposited but not yet reached start_dynasty

[djrtwo]

Issue

We don't currently handle this case. I started adding a bunch of specific logic for this case, but I think maybe we should just prevent a user from being slashed until they enter their start dynasty. This would keep things simple from a contract perspective. It would just potentially complicate logic from slash-watcher's perspective.

[djrtwo]

Thoughts @ChihChengLiang, @paulhauner?

[paulhauner]

I will follow this up and reply here in a few days :)

[ChihChengLiang]

I would say maximizing benefits for the contract is the priority for time being.

[paulhauner]

Slash-watchers already need to maintain a persistent list of vote msgs, so having another list of "future slashes" doesn't seem like a paradigm shift for them.

As you said, it'll add some complexity to slash-watchers but remove some from the contract. I'm generally in favor of pushing complexity off-chain, especially in a case like this were the contract is critical and there's a strong incentive (~60 ETH) to manage the off-chain complexity well.

So yeah, seems like a good call to me 👍