Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Prevent slash before start_dynasty #167

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 6, 2018

Addresses #146

the simplest solution from the contract perspective was to prevent slashing until start_dynasty is reached. Any other solution required a lot of extra contract logic to handle updating dynasty_wei_delta and a other details...

I think this is the best solution, but am open to discussion.

This is built off of #165. so #165 should be merged and reviewed first.

@djrtwo djrtwo requested a review from ChihChengLiang June 7, 2018 12:42
@djrtwo djrtwo closed this Jun 7, 2018
@djrtwo djrtwo reopened this Jun 7, 2018
Copy link
Contributor

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djrtwo djrtwo merged commit 6feca0b into ethereum:master Jun 14, 2018
@djrtwo djrtwo deleted the slash-before-start branch June 14, 2018 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants