Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7702: Set EOA account code [devnet-5 version] #961

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 25, 2024

Depends on ethereum/evmc#720

Note: with the future change to EXTCODE* behavior, it will no longer be required to resolve delegation on the Host side, because Host::code_copy() will return full delegation designator and EVM could resolve it from that. So EVMC change could be simplified (not require Host::get_delegate_address())

@gumb0 gumb0 self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 91.37466% with 32 lines in your changes missing coverage. Please review.

Project coverage is 93.51%. Comparing base (6b7305e) to head (ab37898).

Files with missing lines Patch % Lines
test/state/state.cpp 73.68% 15 Missing ⚠️
test/state/transaction.cpp 20.00% 8 Missing ⚠️
lib/evmone/instructions_calls.cpp 85.18% 4 Missing ⚠️
test/state/errors.hpp 0.00% 4 Missing ⚠️
test/statetest/statetest_loader.cpp 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   94.29%   93.51%   -0.79%     
==========================================
  Files         159      160       +1     
  Lines       17323    17670     +347     
==========================================
+ Hits        16335    16524     +189     
- Misses        988     1146     +158     
Flag Coverage Δ
eof_execution_spec_tests 15.75% <11.32%> (-0.15%) ⬇️
ethereum_tests 26.48% <9.70%> (-0.40%) ⬇️
ethereum_tests_silkpre 18.71% <8.76%> (-0.26%) ⬇️
execution_spec_tests ?
unittests 89.24% <91.37%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/instructions.hpp 100.00% <ø> (ø)
test/state/account.hpp 100.00% <ø> (ø)
test/state/host.cpp 100.00% <100.00%> (ø)
test/state/host.hpp 100.00% <ø> (ø)
test/state/state.hpp 100.00% <100.00%> (ø)
test/state/state_diff.hpp 100.00% <ø> (ø)
test/state/test_state.cpp 100.00% <100.00%> (ø)
test/state/transaction.hpp 100.00% <ø> (ø)
test/statetest/statetest_runner.cpp 96.87% <ø> (-0.27%) ⬇️
test/unittests/evm_eof_calls_test.cpp 100.00% <100.00%> (ø)
... and 7 more

... and 6 files with indirect coverage changes

@gumb0 gumb0 force-pushed the eip-7702 branch 4 times, most recently from 5e9c460 to 7f9d123 Compare July 29, 2024 13:27
@gumb0 gumb0 changed the title WIP EIP-7702 implementation EIP-7702: Set EOA account code Jul 29, 2024
@gumb0 gumb0 force-pushed the eip-7702 branch 9 times, most recently from ccc3776 to 90c05f4 Compare August 2, 2024 18:22
@gumb0 gumb0 force-pushed the eip-7702 branch 8 times, most recently from 056e8ae to a919431 Compare August 8, 2024 09:31
@gumb0 gumb0 force-pushed the eip-7702 branch 6 times, most recently from e19a72a to 3ff5253 Compare August 19, 2024 16:26
@gumb0 gumb0 force-pushed the eip-7702 branch 2 times, most recently from 4d74338 to 2677eaa Compare January 13, 2025 11:47
@gumb0 gumb0 requested review from chfast and pdobacz January 13, 2025 11:59
@gumb0 gumb0 force-pushed the eip-7702 branch 7 times, most recently from 93a4fbb to 47f81cd Compare January 20, 2025 16:27
@gumb0 gumb0 force-pushed the eip-7702 branch 2 times, most recently from c9689ee to 01a1eaf Compare January 22, 2025 11:33
@chfast chfast added the Prague Changes for Prague upgrade label Jan 24, 2025
@chfast
Copy link
Member

chfast commented Jan 24, 2025

Remember to drop "WARNING: test case with set_code transaction (type 4) skipped".
Added a commit for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prague Changes for Prague upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants