Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fw,tests): EIP-7742: Framework changes #931

Merged
merged 13 commits into from
Dec 5, 2024
Merged

feat(fw,tests): EIP-7742: Framework changes #931

merged 13 commits into from
Dec 5, 2024

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Oct 31, 2024

🗒️ Description

Adds the required framework changes for EIP-7742 within pectra devnet-5.

Fills with the following EELS resolution change for Prague:

    "Prague": {
        "git_url": "https://github.com/spencer-tb/execution-specs.git",
        "branch": "forks/prague",
        "commit": "857c3fa4d733535f32e9f17250d5790dd7ab5a76"
    }

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added scope:tests Scope: Test cases type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels Oct 31, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments and suggestions. We should definitely create test folder tests/prague/eip7742_blob_target_max_from_cl or similar, and add tests there for added coverage.

src/ethereum_clis/types.py Outdated Show resolved Hide resolved
src/ethereum_test_forks/forks/forks.py Show resolved Hide resolved
tests/cancun/eip4844_blobs/test_blob_txs.py Outdated Show resolved Hide resolved
@spencer-tb spencer-tb changed the title feat(fw,tests): pectra devnet-5 updates including eip7742 feat(fw,tests): eip7742 framework changes for pectra devnet-5 Nov 20, 2024
@spencer-tb spencer-tb force-pushed the pectra-devnet-5 branch 2 times, most recently from 132fa98 to 62b5787 Compare November 20, 2024 11:23
@spencer-tb spencer-tb marked this pull request as ready for review November 20, 2024 11:45
@danceratopz danceratopz added the fork:prague Prague hardfork label Dec 2, 2024
@spencer-tb spencer-tb mentioned this pull request Dec 4, 2024
4 tasks
@spencer-tb
Copy link
Contributor Author

I would ideally like to find a way to use these: 54510b5#diff-74e82fed735a75dc81ad1d6de01749bd9b537024a67ca3afbde48e9f3fbe82e4L1247-L1259

When filling cancun tests for prague - but its not essential right now

@marioevz marioevz changed the title feat(fw,tests): eip7742 framework changes for pectra devnet-5 feat(fw,tests): EIP-7742: Framework changes Dec 4, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks!

@marioevz marioevz merged commit ed433a7 into main Dec 5, 2024
6 checks passed
@marioevz marioevz deleted the pectra-devnet-5 branch December 5, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:prague Prague hardfork scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Test cases type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants