Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EIP 7742 in Prague #1045

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

petertdavies
Copy link
Collaborator

@petertdavies petertdavies commented Dec 3, 2024

This PR implements EIP 7742 on top of Prague. It have done some brief tests with the execution-spec-tests PR and these changes seem to work.

This PR should not be merged since the status of EIP 7742 is very uncertain.

Please check that EIP 7742 is actually going into prague-devnet-5 before merging.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@petertdavies petertdavies changed the base branch from forks/prague to devnets/prague/5 December 5, 2024 21:20
@petertdavies petertdavies marked this pull request as ready for review December 5, 2024 21:20
@spencer-tb
Copy link
Contributor

Thanks again for adding this :D

We were wondering the following should be added too:
spencer-tb@07f4774#diff-1ead0e19bcf5b72f6e0ff1f07a9d44a25a738020803d5ea42839da1e3d58a8c5R433-R434

Checking for contract creating blob txs!

@marioevz
Copy link
Member

Created petertdavies#4 to implement changes in ethereum/EIPs#9122.

On a side note, I'm seeing zero value in the result's field blobGasUsed, regardless of whether a blob is included in the transactions or not, I'm not sure if this is derived from the changes in this PR though @gurukamath

@gurukamath
Copy link
Collaborator

On a side note, I'm seeing zero value in the result's field blobGasUsed, regardless of whether a blob is included in the transactions or not, I'm not sure if this is derived from the changes in this PR though @gurukamath

Could this be the issue?

@gurukamath
Copy link
Collaborator

LGTM!

petertdavies and others added 6 commits December 19, 2024 11:10
In addition to implementing the EIP-7691, this commit also changes the name of the variable from BLOB_GASPRICE_UPDATE_FRACTION to BLOB_BASE_FEE_UPDATE_FRACTION. This aligns the variable name as defined in EIP-4844
@petertdavies petertdavies merged commit b0005fb into ethereum:devnets/prague/5 Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants