-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add releasing guidelines #1077
base: master
Are you sure you want to change the base?
Add releasing guidelines #1077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, thanks Sam! Looks good to me.
I caught myself mentally mapping dev
to "devnet", but my brain's getting used to it (it's a shame .pre
doesn't exist).
The "preview" -> "finalize" -> "bugfix" devnet flow maps well to the new devnet launch process: Launch now requires all hive tests to pass.
I wrote a script to ensure the versions are valid and tried to generate a human readable version of all the releases included in this doc, here's the output:
1.15.0rc1.dev1 EELS (v1) release of Cancun for devnet-1, pre-release-v1
1.15.0rc1.dev2 EELS (v1) release of Cancun for devnet-1, pre-release-v2
1.15.0rc1.dev3 EELS (v1) release of Cancun for devnet-1, pre-release-v3
1.15.0rc1 EELS (v1) release of Cancun for devnet-1 (version at devnet launch)
1.15.0rc1.post1 EELS (v1) release of Cancun for devnet-1, bug-fix-release-1
1.15.0rc1.post2 EELS (v1) release of Cancun for devnet-1, bug-fix-release-2
1.15.0rc1.post3 EELS (v1) release of Cancun for devnet-1, bug-fix-release-3
1.15.0rc2 EELS (v1) release of Cancun for devnet-2 (version at devnet launch)
1.15.0 EELS (v1) release of Cancun for mainnet (version at hardfork)
1.15.1 EELS (v1) release of Cancun for mainnet, bug-fix-release1 (post hardfork)
2.15.0 EELS (v2) release of Cancun for mainnet (version at hardfork)
2.16.0rc1.dev1 EELS (v2) release of Prague for devnet-1, pre-release-v1
2.16.0rc1 EELS (v2) release of Prague for devnet-1 (version at devnet launch)
2.16.0 EELS (v2) release of Prague for mainnet (version at hardfork)
1.3.5 EELS (v1) release of Tangerine Whistle for mainnet, bug-fix-release5 (post hardfork)
1.4.0 EELS (v1) release of Spurious Dragon for mainnet (version at hardfork)
1.4.0rc1 EELS (v1) release of Spurious Dragon for devnet-1 (version at devnet launch)
1.3.6 EELS (v1) release of Tangerine Whistle for mainnet, bug-fix-release6 (post hardfork)
2.3.0 EELS (v2) release of Tangerine Whistle for mainnet (version at hardfork)
1.3.0rc5 EELS (v1) release of Tangerine Whistle for devnet-5 (version at devnet launch)
1.3.0rc6 EELS (v1) release of Tangerine Whistle for devnet-6 (version at devnet launch)
1.3.0rc5.post1 EELS (v1) release of Tangerine Whistle for devnet-5, bug-fix-release-1
2.3.0rc5 EELS (v2) release of Tangerine Whistle for devnet-5 (version at devnet launch)
1.3.0rc5.post7 EELS (v1) release of Tangerine Whistle for devnet-5, bug-fix-release-7
1.3.0rc5.post8 EELS (v1) release of Tangerine Whistle for devnet-5, bug-fix-release-8
1.3.5.dev7 EELS (v1) release of Tangerine Whistle for mainnet, bug-fix-release5 (post hardfork), pre-release-v7
1.3.5.dev8 EELS (v1) release of Tangerine Whistle for mainnet, bug-fix-release5 (post hardfork), pre-release-v8
1.3.0rc5.dev7 EELS (v1) release of Tangerine Whistle for devnet-5, pre-release-v7
1.3.0rc5.dev8 EELS (v1) release of Tangerine Whistle for devnet-5, pre-release-v8
1.3.0rc5.post7.dev9 EELS (v1) release of Tangerine Whistle for devnet-5, bug-fix-release7, pre-release-v9
1.3.0rc5.post7.dev10 EELS (v1) release of Tangerine Whistle for devnet-5, bug-fix-release7, pre-release-v10
That's super cool! Would you be willing to make it into a lint (similar to |
c28dda6
to
04b3485
Compare
Are we aiming for compatibility with semver? |
04b3485
to
c945ae9
Compare
Added a bit of text explaining it, but in short, no. |
The two information: EELS API for downstream apps + network dependency (upstream for EELS) is fighting for real estate in the version string. Each require their own "dev" namespace. This causes jumping of minor versions when there is a breaking change in EELS. Say 1.16.0 to 2.17.0 (where >=2.0.0, <2.16.0 releases may not exist!); this is because we use minor to represent fork. We could separate this out using a local identifier for forks: This can be extended to include release (or dev) candidates for EELS. |
The benefit of having two namespaces would be to express "a preview of code for the final specification" and "final code for a preview of the specification" separately?
Are missing releases a problem? If so, why?
Unfortunately you cannot publish packages with local identifiers to PyPI:
|
What was wrong?
Related to Issue #290
How was it fixed?
Added a document describing the release process.
Cute Animal Picture