-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EIP 7623: calldata cost increase #3813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochem-brouwer
force-pushed
the
eip-7623
branch
from
December 16, 2024 15:42
f7a7427
to
7e8562e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
reviewed
Dec 16, 2024
jochem-brouwer
added
PR state: needs review
and removed
PR/Issue state: blocked
PR state: WIP
labels
Dec 19, 2024
jochem-brouwer
added a commit
that referenced
this pull request
Jan 13, 2025
* evm: add devnet-5 EIP-7702 changes * vm: add devnet-5 EIP-7685 changes * monorepo: make cspell happy * vm/client: fix tests * evm: remove redundant test * remove accidental console.log * remove 7742 and add 7691 independently * fix t8ntool empty requests reporting * client: fix engine reporting empty requests * t8n: fix requests reporting * Implement EIP 7623: calldata cost increase (#3813) * common/evm/vm: implement EIP7623 calldata cost increase * move the floorcost update and add debug log * fix t8ntool empty requests reporting * common: add 7623 * tx: add 7623 validator * t8n: throw on invalid txs * make cspell happy --------- Co-authored-by: harkamal <[email protected]> * client: fix requests contract address (devnet-5) (#3818) * update chainid to uint256 * evm: update bls gas (eips PR 9097) * evm: bls update msm gas (eips PR 9116) * evm: bls update pairing gas (eips PR 9098) * evm: rename bls files and remove g1mul, g2mul (eips PR 8945) * evm: update 2537 addresses in test * tx: add eip-7691 param * tx: add required params to common * vm/tests: update 7002 test: correctly deploy withdrawal contract * client: update genesis contracts * evm: update bls test files * vm: 2935 update history serve window * evm: EXTCODE* do not follow 7702 delegations for gas calculations * vm: t8n fix: exit early on non-existent 2935 code * vm: move floor check after applying refund * evm: update bls cases * evm/common: cleanup pr * monorepo: casing maxblob -> maxBlob * tx: tx tests support prague * tx: add missing forks * client: switch cl request types --------- Co-authored-by: harkamal <[email protected]> Co-authored-by: Lucas Saldanha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements EIP 7623 https://github.com/ethereum/EIPs/blob/da2a86bf15044416e8eb0301c9bdb8d561feeb32/EIPS/eip-7623.md
EEST ref: https://github.com/ethereum/execution-specs/pull/966/files
WIP, need to write tests and currently not sure about this implementation. (Added blocked, don't merge in devnet-5 spec PR #3807)