Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use unittest assert methods #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

etingof
Copy link
Owner

@etingof etingof commented Nov 23, 2019

Changed assertion in unit tests from Python built-in to unittest provided. The motivation is to have better reporting on test failures.

@codecov-io
Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files          26       26           
  Lines        4662     4662           
=======================================
  Hits         3986     3986           
  Misses        676      676

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb6e5b...4d5a3fe. Read the comment docs.

@etingof etingof force-pushed the add-unittest-assertion branch 3 times, most recently from dd7bb32 to 9006905 Compare November 24, 2019 09:08
Changed assertion in unit tests from Python built-in
to `unittest` provided. The motivation is to have better
reporting on test failures.
@etingof etingof force-pushed the add-unittest-assertion branch from 9006905 to 4d5a3fe Compare November 24, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants