Add euphorie.htmllaundry module #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except that we removed the imports from the init and replaced with a thank-you note to Wichert.
It fails with latest lxml 5.2 (Plone 6.0.11).
|
If someone gives me write access to https://github.com/syslabcom/htmllaundry I can push a change there and create a PR. |
I added you! |
And it *must* be a list with lxml 5.2 (new lxml_html_cleaner package), otherwise you get an error when instantiating the cleaner: ``` TypeError: Expected a collection, got str: link_target='_blank' ```
In lxml 5.2+ `from lxml.html.clean import Cleaner` still works, but only if the `lxml_html_clean` is available, and then it is a backwards compatibility import.
Thanks @pilz. Alternative PR created: syslabcom/htmllaundry#2 |
…etup The tests folder must be a module for the tests to be discovered
ale-rt
approved these changes
May 21, 2024
|
I would very much prefer going with this version rather than going on with the fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
htmllaundrypackage fails withlxml5.2 (Plone 6.0.11).Just thinking: alternatively we could fix
htmllaundryand push a new version to PyPI. We do have access: https://pypi.org/project/htmllaundry/We have already fixed this in at least one other project, and Alessandro and me identified at least one other project that uses it.