Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizon 2.5 #14

Merged
merged 11 commits into from
Aug 21, 2024
Merged

Horizon 2.5 #14

merged 11 commits into from
Aug 21, 2024

Conversation

AdrienDucourthial
Copy link
Collaborator

No description provided.

@ArcRiiad
Copy link
Member

ArcRiiad commented May 29, 2024

Hello Adrien!

Petite question sur les tests d'intégrations, je remarque que sur les tests ou ça doit fail un ignore_error: yes y a une raison en particulier de faire ça plutôt que des register suivi d'assert? 😄

Je te link la partie de la doc qui explique comment faire cet assert (https://docs.ansible.com/ansible/latest/community/collection_contributors/collection_integration_about.html#covering-modules-new-features)

une fois que ce sujet est résolu, je vais procéder à la review de code!

@antoninguyot antoninguyot removed their request for review July 11, 2024 13:20
@Etiennelv Etiennelv merged commit 8115988 into main Aug 21, 2024
1 of 2 checks passed
@Etiennelv Etiennelv deleted the horizon-2.5 branch August 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants