Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gleam to 1.4.1 and update deps #74

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

ducdetronquito
Copy link
Contributor

Hi !

While doing the Bandwagoner exercise, I realized that I could not use the shorthand syntax for labels implemented in Gleam 1.4.0 because the test runner uses Gleam 1.3.2.

This modification make it run fine on my machine with Docker, but I hope there is nothing missing in this PR.

Have a nice day :)

@ducdetronquito ducdetronquito requested a review from a team as a code owner August 14, 2024 14:19
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something for @lpil to look at

The compiler does not generate the following warning anymore:

```
warning: Unused imported module
  ┌─ test/empty_file_test.gleam:2:1
  │
2 │ import exercism/should
  │ ^^^^^^^^^^^^^^^^^^^^^^ This imported module is never used
Hint: You can safely remove it.
```
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thank you

@lpil lpil merged commit 26da482 into exercism:main Aug 15, 2024
1 check passed
@ducdetronquito ducdetronquito deleted the task/bump-gleam-and-update-deps branch August 15, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants