Review feedback 01/11

f3d-app · Jan 11, 2025 · b1ee28f · b1ee28f
1 parent 5255c07
commit b1ee28f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/application/testing/CMakeLists.txt b/application/testing/CMakeLists.txt
@@ -833,7 +833,7 @@ f3d_test(NAME TestInteractionOrthographicProjection DATA cow.vtp INTERACTION) #5
 f3d_test(NAME TestInteractionZoomToggleOrthographicProjection DATA cow.vtp INTERACTION) #MouseWheel;5;Mousewheelx6;5
 f3d_test(NAME TestInteractionRotateCameraMinus90 DATA f3d.glb INTERACTION)
 f3d_test(NAME TestInteractionRotateCamera90 DATA f3d.glb INTERACTION)
-f3d_test(NAME TestInteractionRollCameraRotation DATA f3d.glb INTERACTION) #1;4;LeftMouse;MouseMovements
+f3d_test(NAME TestInteractionRollCameraRotation DATA f3d.glb ARGS -g INTERACTION) #1;4;LeftMouse;MouseMovements
 f3d_test(NAME TestInteractionPanWithShift DATA f3d.glb INTERACTION) #Shift;LeftMouse;MouseMovements
 f3d_test(NAME TestInteractionConsoleOpen DATA f3d.glb INTERACTION UI) #Escape
 f3d_test(NAME TestInteractionConsoleOpenExit DATA f3d.glb REGEXP "Interactor has been stopped" INTERACTION NO_BASELINE UI) #Escape;exit;Return

diff --git a/testing/baselines/TestInteractionRollCameraRotation.png b/testing/baselines/TestInteractionRollCameraRotation.png
diff --git a/vtkext/private/module/vtkF3DInteractorStyle.cxx b/vtkext/private/module/vtkF3DInteractorStyle.cxx
@@ -153,7 +153,7 @@ void vtkF3DInteractorStyle::Rotate()
   double dir[3];
   camera->GetDirectionOfProjection(dir);
   double* up = ren->GetUpVector();
-  InterpolateTemporaryUp(0.1, up);
+  this->InterpolateTemporaryUp(0.1, up);
   up = this->TemporaryUp;
 
   double dot = vtkMath::Dot(dir, up);