Cli reader options #1860
Open
Cli reader options #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1860 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 125 125
Lines 10013 10015 +2
=======================================
+ Hits 9572 9574 +2
Misses 441 441 ☔ View full report in Codecov by Sentry. |
mwestphal
reviewed
Jan 3, 2025
mwestphal
reviewed
Jan 3, 2025
mwestphal
reviewed
Jan 3, 2025
mwestphal
reviewed
Jan 11, 2025
mwestphal
reviewed
Jan 11, 2025
mwestphal
reviewed
Jan 11, 2025
mwestphal
reviewed
Jan 11, 2025
mwestphal
reviewed
Jan 11, 2025
mwestphal
reviewed
Jan 11, 2025
library/src/factory.cxx.in
Outdated
| @@ -49,7 +49,11 @@ reader* factory::getReader(const std::string& fileName) | |||
| { | |||
| for (auto r : p->getReaders()) | |||
| { | |||
| if (r->getScore() > bestScore && r->canRead(fileName)) | |||
| if (forceReader.has_value() && r->getName() == *forceReader) | |||
There was a problem hiding this comment.
Suggested change
| if (forceReader.has_value() && r->getName() == *forceReader) | |
| if (forceReader.has_value() && r->getName() == forceReader.value()) |
There was a problem hiding this comment.
Just wondering, since we already check has_value(), should I still switch to forceReader.value() even though it adds a bit of overhead?
mwestphal
reviewed
Jan 11, 2025
mwestphal
reviewed
Jan 11, 2025
mwestphal
reviewed
Jan 11, 2025
application/F3DOptionsTools.cxx
Outdated
| @@ -65,6 +65,7 @@ static inline const std::array<CLIGroup, 8> CLIOptions = {{ | |||
| { "no-background", "", "No background when render to file", "<bool>", "1" }, | |||
| { "help", "h", "Print help", "", "" }, { "version", "", "Print version details", "", "" }, | |||
| { "list-readers", "", "Print the list of readers", "", "" }, | |||
| {"force-reader", "", "Enforce a specific reader", "<reader>", "1"}, | |||
There was a problem hiding this comment.
please add an application test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a CLI reader option #1735