Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image::compare #1863

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Refactor image::compare #1863

merged 5 commits into from
Jan 3, 2025

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Jan 3, 2025

No description provided.

@Meakk Meakk self-assigned this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@Meakk Meakk requested a review from mwestphal January 3, 2025 13:59
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming other bindings (wasm, java) are not impacted

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (5404aee) to head (5450f0b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
- Coverage   95.69%   95.65%   -0.04%     
==========================================
  Files         125      125              
  Lines        9894     9897       +3     
==========================================
- Hits         9468     9467       -1     
- Misses        426      430       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Meakk Meakk merged commit 7ae6a1a into f3d-app:master Jan 3, 2025
48 checks passed
@Meakk Meakk deleted the image-compare branch January 3, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants