Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release into master #1893

Merged
merged 15 commits into from
Jan 8, 2025
Merged

Merge release into master #1893

merged 15 commits into from
Jan 8, 2025

Conversation

mwestphal
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jan 8, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@mwestphal mwestphal requested a review from Meakk January 8, 2025 07:53
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 97.86780% with 10 lines in your changes missing coverage. Please review.

Project coverage is 95.67%. Comparing base (af034e1) to head (befea17).
Report is 63 commits behind head on master.

Files with missing lines Patch % Lines
library/src/utils.cxx 60.00% 4 Missing ⚠️
...t/private/module/vtkF3DInteractorEventRecorder.cxx 0.00% 4 Missing ⚠️
library/src/engine.cxx 96.72% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
- Coverage   95.68%   95.67%   -0.01%     
==========================================
  Files         123      125       +2     
  Lines        9756     9950     +194     
==========================================
+ Hits         9335     9520     +185     
- Misses        421      430       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal merged commit 7cc980f into master Jan 8, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants