Improve clang-format #1912
Open
Improve clang-format #1912
+288
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Meakk
commented
Jan 12, 2025
•
Meakk
commented
- Added missing folders
- Upgrade to version 18
- Made related changes
|
You are modifying libf3d public API! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1912 +/- ##
==========================================
- Coverage 95.69% 95.59% -0.11%
==========================================
Files 125 125
Lines 9997 10013 +16
==========================================
+ Hits 9567 9572 +5
- Misses 430 441 +11 ☔ View full report in Codecov by Sentry. |
Merged
Meakk
force-pushed
the
improve-clang-format
branch
from
6295157 to
7b42691
Compare
Meakk
force-pushed
the
improve-clang-format
branch
from
7b42691 to
a94fe74
Compare
mwestphal
reviewed
Jan 12, 2025
| * No input checking on camIndex | ||
| * Please note `void SetCamera(vtkIdType camIndex);` is not reimplemented nor used. | ||
| * Implement vtkImporter camera API by adding cameras for each individual importers one after the | ||
| * other No input checking on camIndex Please note `void SetCamera(vtkIdType camIndex);` is not |
There was a problem hiding this comment.
Suggested change
| * other No input checking on camIndex Please note `void SetCamera(vtkIdType camIndex);` is not | |
| * other No input checking on camIndex. Please note `void SetCamera(vtkIdType camIndex);` is not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.