Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating copyright headers to match current best practices #1301

Merged
merged 20 commits into from
May 26, 2020
Merged

Updating copyright headers to match current best practices #1301

merged 20 commits into from
May 26, 2020

Conversation

tmichalak
Copy link
Contributor

@tmichalak tmichalak commented Apr 15, 2020 •
edited
Loading

Made applicable changes mentioned in f4pga/ideas#47

  • Renamed the COPYING file
  • Removed All rights reserved
  • Updated the year
  • Added short version of ISC license header to all *.cc and *.h files
  • Added short version of ISC license header to all *.py scripts
  • Added short version of ISC license header to all bash scripts
  • Added short version of ISC license header to all Makefiles
  • Added the SPDX identifier to the license headers

@tmichalak tmichalak requested a review from mithro April 15, 2020 10:16
mithro
mithro reviewed Apr 15, 2020
View reviewed changes
LICENSE Outdated Show resolved Hide resolved
@tmichalak
Copy link
Contributor Author

@mithro We also want a license headers in .py and .tcl files, right? Also with the short version of the ISC header?

@mithro
Copy link
Contributor

mithro commented Apr 15, 2020

@tmichalak - Any code file, .py, .tcl, Makefile, .sh, etc......

@tmichalak tmichalak force-pushed the licensing branch 6 times, most recently from f216e67 to 8af81b1 Compare April 16, 2020 14:10
aimylios
aimylios reviewed Apr 17, 2020
View reviewed changes
minitests/roi_harness/runme.sh Outdated Show resolved Hide resolved
vagrant/profile.d/vivado.sh Outdated Show resolved Hide resolved
mithro
mithro reviewed Apr 17, 2020
View reviewed changes
.github/kokoro/db-full.sh Outdated Show resolved Hide resolved
mithro
mithro requested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you go through the checklist at f4pga/ideas#47 and confirm that everything there has been covered. If so, please re-request my review on this pull request and I'll take another look.

@mithro mithro linked an issue Apr 22, 2020 that may be closed by this pull request
Add license header to top of all code files #1300
Closed
@mithro mithro changed the title Update licensing information Updating copyright headers to match current best practices Apr 22, 2020
@tmichalak tmichalak requested a review from mithro April 24, 2020 11:35
@tmichalak
Copy link
Contributor Author

@mithro I fixed the bug you mentioned and also added a license check to Travis. The checks currently fail with:

ERROR: fasm does not have the LICENSE file.
ERROR: python-sdf-timing does not have the LICENSE file.

which shall go away once the licensing PRs for fasm and python-sdf-timing are merged.

@tmichalak tmichalak requested a review from mithro May 6, 2020 04:36
tmichalak added 12 commits May 26, 2020 07:33
@tmichalak @mithro
Rename COPYING file and update licensing information
4951b95 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add licensing header to C++ source and header files
bb400b4 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add licensing header to python scripts
e8311ca 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add licensing header to fuzzers' python scripts
950d753 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add licensing header to rest of python scripts
93b7792 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add licensing header to Makefiles
159d6a8 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add licensing header to bash scripts
300bc62 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Fix formatting after updating license headers
0357b3e 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add AUTHORS file
155103b 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add or fix license header
fbf4dd8 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add license headers to tcl files
c66f4f4 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@tmichalak @mithro
Add license check step to Travis
631b07b 
Signed-off-by: Tomasz Michalak <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
mithro added 8 commits May 26, 2020 07:34
@mithro
Adding license header to check_license.sh script.
aeb619c 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
Adding license header to check_python_scripts.sh
e82b22f 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
Fix Claire's name.
c6a5829 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
travis: Convert the checking stuff to scripts.
072fc6a 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
Exclude build directory from check_license.
4d253e0 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
Add check-license to Makefile.
29b9896 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
fasm: Roll fasm forward to get new license file.
2e2aa5f 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
Rolling third_party/python-sdf-timing forward.
f0d4a71 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro mithro merged commit 1f41082 into f4pga:master May 26, 2020
@mithro mithro deleted the licensing branch May 26, 2020 16:01
@mithro mithro mentioned this pull request Apr 11, 2021
Closed
@mithro
Copy link
Contributor

mithro commented Apr 11, 2021

This fixed #1306

@mithro mithro linked an issue Apr 11, 2021 that may be closed by this pull request
Add license automated check in Travis #1306
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimylios aimylios aimylios left review comments

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
parts-docs parts-experiments parts-fuzzers parts-infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license automated check in Travis Add license header to top of all code files
4 participants
@tmichalak @mithro @aimylios @symbiflow-kokoro