Skip to content

Commit

Permalink
Update extract-docker-binaries.sh to pull from the correct image tag (#…
Browse files Browse the repository at this point in the history
…2050)

Summary:
Pull Request resolved: #2050

Building the local binaries was failng with:
```
Unable to find image 'fbpcs/onedocker:brian-standard-build' locally
Error response from daemon: pull access denied for fbpcs/onedocker, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
```

This is because the local test onedocker image tag was changed to fbpcs/onedocker/test.

This won't affect prod because the [prod workflow](https://fburl.com/code/trv85s87) passes an image name so it doesn't use the default values.

Differential Revision: D42626642

fbshipit-source-id: 41d7a8af41af4d0c8375520160d25f3aecba975c
  • Loading branch information
musebc authored and facebook-github-bot committed Jan 23, 2023
1 parent e8666e5 commit a5d6329
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions extract-docker-binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ if [ -z "$DOCKER_IMAGE_NAME" ]; then
case $PACKAGE in
emp_games) DOCKER_IMAGE_NAME="fbpcs/emp-games";;
data_processing) DOCKER_IMAGE_NAME="fbpcs/data-processing";;
pid) DOCKER_IMAGE_NAME="fbpcs/onedocker";;
validation) DOCKER_IMAGE_NAME="fbpcs/onedocker";;
pid) DOCKER_IMAGE_NAME="fbpcs/onedocker/test";;
validation) DOCKER_IMAGE_NAME="fbpcs/onedocker/test";;
esac
fi
DOCKER_IMAGE_PATH="${DOCKER_IMAGE_NAME}:${TAG}"
Expand Down

0 comments on commit a5d6329

Please sign in to comment.