Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Update deprecated Magnum mouse APIs. #2130

Merged
merged 1 commit into from
Jan 14, 2025
Merged

HITL - Update deprecated Magnum mouse APIs. #2130

merged 1 commit into from
Jan 14, 2025

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jan 13, 2025

Motivation and Context

This changeset updates HITL to use the new Magnum pointer API. See: facebookresearch/habitat-sim#2521

How Has This Been Tested

Tested locally.

Types of changes

  • [Dependency Upgrade]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 13, 2025
aclegg3
aclegg3 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit 5101b63 into main Jan 14, 2025
4 checks passed
@0mdc 0mdc deleted the 0mdc/magnum_update branch January 14, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot