Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[WIP][Habitat 3.0] - PBR tests and defaults #2230

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

--[WIP][Habitat 3.0] - PBR tests and defaults #2230

wants to merge 1 commit into from

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Oct 6, 2023 •
edited
Loading

Motivation and Context

This PR will add tests to verify the integrity of the PBR rendering, including the results from IBL.

Still a WIP

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 6, 2023
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 6 times, most recently from 7f64b4d to 6ed4462 Compare October 16, 2023 17:42
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from 8ca6daf to e8a8ee4 Compare October 26, 2023 15:20
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from 3dbf5e7 to acd94cd Compare November 29, 2023 14:38
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 4 times, most recently from c0985ad to 345219f Compare December 12, 2023 17:25
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from 4bb0871 to 0809919 Compare January 4, 2024 13:52
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from f470cb8 to fe1a409 Compare January 9, 2024 21:12
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from fdea562 to b9e1587 Compare January 29, 2024 19:21
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 3 times, most recently from 7e07e6f to 9b42300 Compare February 7, 2024 16:00
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from cb7ae6e to 4265fa4 Compare February 15, 2024 14:07
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 4 times, most recently from b929452 to ca6042e Compare May 13, 2024 18:49
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from b605db3 to 30c0292 Compare June 18, 2024 13:51
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from 1bff7df to 570b272 Compare July 25, 2024 15:27
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from 06acd0c to 2031f13 Compare August 13, 2024 14:01
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from d2b7f8e to 60fc973 Compare August 25, 2024 15:47
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from 3d6b1c8 to 88c2b10 Compare September 5, 2024 12:57
@jturner65 jturner65 changed the base branch from main to dev September 17, 2024 14:26
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from bcbd91a to fcf6056 Compare September 18, 2024 17:17
Base automatically changed from dev to main November 4, 2024 16:35
@jturner65 jturner65 force-pushed the PBR_RenderTests branch 2 times, most recently from 5f79723 to c0685ac Compare November 13, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jturner65 @facebook-github-bot