Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show also current in overview video? #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dneise
Copy link
Member

@dneise dneise commented Mar 23, 2017

Adrian an me were talking about the lid, and what if the lid does not fully open. The system would not realize that and the starting shifter might not notice this in a webcam or so..
So we might take happily data with a half open lid.

I think, this is more or less okay, as long as we realize this at least during the next day ... and not after a week or month....

So we though, the overview video should maybe include something like the currents ... this would show a half open lid ...

And also ... I think, we get a nice handle on spotting hardware defects ... for just one minute of video ...
So I researched how to make screenshots of websites using javascript. And found a lot of ways involving hard to install stuff.

The easiest by far for me seemed selenium, which is pip installable. Together with PhantomJS, which is apt-get, homebrew and npm installable, so I hope this can even run on Travis, in case we wanna go for testing.

At the moment, this will fail with such an exception (in the logs)

selenium.common.exceptions.WebDriverException: Message: 'phantomjs' executable needs to be in PATH.

resulting in the same black images, we get when the webcam page is down or so.

In case phantomjs was not installed e.g. like this:

sudo apt-get install phantomjs

@dneise
Copy link
Member Author

dneise commented Mar 23, 2017

foo

Here is how this PR looks like.
Of course the arrangement of the images is widely open to discussion.

And as you see here.
https://github.com/fact-project/la_palma_overview/pull/8/files#diff-dd6036fd7f0b95f2f22605cc5438a064R227

I just grab the image about 40% higher than needed and then simply cut out the lower part in order to get a "kind of nice" image of the camera without all the text on top. Of course these "40%" should depend on the number of lines the smarfact page has.

@dneise dneise requested review from maxnoe and relleums March 23, 2017 17:02
@dneise
Copy link
Member Author

dneise commented Mar 24, 2017

Damn .. I wanted to let it run for the rest of the night .. but forgot it .. so here just some minutes of this morning

https://youtu.be/yixvjf8ZUe0

@maxnoe
Copy link
Member

maxnoe commented Mar 24, 2017

I do not how but would it be possible to add a large text to the images saying Temperature, Currents etc? So one does not have to remember which image is what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants