Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add support for Google Colab token retrieval #377

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

not-lain
Copy link

@not-lain not-lain commented Jan 3, 2025

this pr will allow for token retrieval from colab secrets, allowing users to use fal across colab notebooks seamlessly.
as demonstrated in this colab notebook
https://colab.research.google.com/drive/1DnBruroSsAhzFoaaSmmlSh96S9s0E5oq?usp=sharing

this pr is inspired by huggingface's token retrieval logic which can be found in https://github.com/huggingface/huggingface_hub/blob/503d35355fa79ede904665c944e0a247e85c8af7/src/huggingface_hub/utils/_auth.py#L35

@not-lain not-lain marked this pull request as draft January 4, 2025 02:41
@not-lain
Copy link
Author

not-lain commented Jan 4, 2025

I have removed all my changes in the previous commit and the tests are still failing, I think it's safe to assume there's something wrong with the workflow, I will bring my changes back and i'll let you investigate this at your own pace.
So far I have tested my changes both locally and on colab and it worked on both of them.

@not-lain not-lain marked this pull request as ready for review January 4, 2025 13:02
@chamini2
Copy link
Member

chamini2 commented Jan 5, 2025

Hello, @not-lain, thanks for the contribution! The failures are because your repo clone does not have the env vars needed to run tests. We have not figured out those details for contributions like this.

We will take some time to test this with our credentials and report back

@efiop efiop self-requested a review January 17, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants