Skip to content

Commit

Permalink
omapfb: dss: Fix max fclk divider for omap36xx
Browse files Browse the repository at this point in the history
There appears to be a timing issue where using a divider of 32 breaks
the DSS for OMAP36xx despite the TRM stating 32 is a valid
number.  Through experimentation, it appears that 31 works.

This same fix was issued for kernels 4.5+.  However, between
kernels 4.4 and 4.5, the directory structure was changed when the
dss directory was moved inside the omapfb directory. That broke the
patch on kernels older than 4.5, because it didn't permit the patch
to apply cleanly for 4.4 and older.

A similar patch was applied to the 3.16 kernel already, but not to 4.4.
Commit 4b911101a5cd ("drm/omap: fix max fclk divider for omap36xx") is
on the 3.16 stable branch with notes from Ben about the path change.

Since this was applied for 3.16 already, this patch is for kernels
3.17 through 4.4 only.

Fixes: f7018c2 ("video: move fbdev to drivers/video/fbdev")
Cc: <[email protected]> ivanmeler#3.17 - 4.4
CC: <[email protected]>
Signed-off-by: Adam Ford <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
Change-Id: Id840cfa9db33962c349da71c1830fa680ae630ee
  • Loading branch information
aford173 authored and Lee Jones committed Sep 16, 2020
1 parent 7543a29 commit 6359f95
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/fbdev/omap2/dss/dss.c
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ static const struct dss_features omap34xx_dss_feats __initconst = {
};

static const struct dss_features omap3630_dss_feats __initconst = {
.fck_div_max = 32,
.fck_div_max = 31,
.dss_fck_multiplier = 1,
.parent_clk_name = "dpll4_ck",
.dpi_select_source = &dss_dpi_select_source_omap2_omap3,
Expand Down

0 comments on commit 6359f95

Please sign in to comment.