chore: make Client::get_config sync #6652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maan2003
force-pushed
the
ma/jj-mrolvkmpkuvn
branch
from
8ceb7d0 to
01dbefc
Compare
auto-merge was automatically disabled
January 6, 2025 20:02
Pull request was converted to draft
|
Is there any reason we might want the fn to be async even though the lock is sync? E.g. needing to read something from the DB in the future? I'm inclined to make things async even if not strictly needed. |
|
even if we read from database, we can always have in memory copy and updating it on writes |
maan2003
force-pushed
the
ma/jj-mrolvkmpkuvn
branch
from
01dbefc to
e2a0a21
Compare
maan2003
force-pushed
the
ma/jj-mrolvkmpkuvn
branch
from
e2a0a21 to
0f9c6f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always use the correct lock for the job