Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TinyGo templates to address static init problems #2977

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

itowlson
Copy link
Contributor

E.g. this should fix static logging objects not being ready, os.Environ(), etc.

See #2184 (comment).

Marking as draft initially to verify that I haven't muddled up the changes and that I've updated CI correctly.

E.g. this should fix static logging objects not being ready, os.Environ(), etc.

Signed-off-by: itowlson <[email protected]>
@itowlson
Copy link
Contributor Author

It was Go 1.21 that introduced wasip1 but that had a lot of patches so I've bumped templates and CI to 1.22. If we'd prefer to be more conservative and use 1.21 instead then I can do that.

@itowlson
Copy link
Contributor Author

CI failed in cabi_realloc. It works locally for me, but a possible difference is that I'm on Go 1.23 rather than 1.22. Trying updating Go in CI and will see how it goes.

@itowlson
Copy link
Contributor Author

Hmm, it seems like the smoke test is trying to test the template in the repo not the template in the PR. Which seems like it makes the CI failure even stranger. Maybe the existing template doesn't work with tinygo 0.35 because of the wasi build target?

@itowlson itowlson force-pushed the tinygo-global-init-fixes branch from 1b4e55a to ee541b8 Compare January 13, 2025 01:23
@itowlson
Copy link
Contributor Author

Yes, running the existing Go template with TinyGo 0.35 / Go 1.23 reproduces the CI error.

I don't know how to validate the new template in CI so this may have to involve people accepting a Works On My Machine.

I'll roll CI back to Go 1.22, and also remove the stub main that's no longer needed.

@itowlson itowlson marked this pull request as ready for review January 13, 2025 01:23
@itowlson itowlson requested review from adamreese and dicej January 13, 2025 01:24
@lann lann merged commit 771282e into fermyon:main Jan 13, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Triage Needed
Development

Successfully merging this pull request may close these issues.

3 participants