Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test flakiness by cloning kex param A #21

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

ben-krieger
Copy link
Member

Fixes #20

NOTE: Not a bug when using HTTP transport - this is only triggered due to how fdotest's transport works.

@bkgoodman Please try to trigger the test flake now. My main development machine has never reproduced it in thousands of runs, though I've seen it on my Chromebook and in CI.

@ben-krieger ben-krieger force-pushed the fix-test-flake-crypto-verify-fails branch from c750d50 to 4b2f400 Compare December 1, 2024 05:10
Copy link

@bkgoodman bkgoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

210 Tests passed - whereas I could only get through about 4 before this fix.

@ben-krieger ben-krieger merged commit a93f721 into main Dec 1, 2024
6 checks passed
@ben-krieger ben-krieger deleted the fix-test-flake-crypto-verify-fails branch December 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test intermittently failing because to2.ProveOVHdr failing due to finalizer clearing xA
2 participants