Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep value in scope until CBOR encoding completes to avoid a finalizer running prematurely #26

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Keep value in scope until CBOR encoding completes to avoid a finalizer running prematurely #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cbor/cbor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ import (
"io"
"math"
"reflect"
"runtime"
"slices"
"sort"
"strconv"
Expand Down Expand Up @@ -1084,6 +1085,11 @@ func (e *Encoder) write(b []byte) error {
//
//nolint:gocyclo // Dispatch will always have naturally high complexity.
func (e *Encoder) Encode(v any) error {
// Reflection does not keep the underlying value in scope, so this is
// needed to keep finalizers from running and possibly modifying the value
// being encoded (such as zeroing secrets).
defer runtime.KeepAlive(v)

// Use reflection to dereference pointers, get concrete types out of
// interfaces, and unwrap named types
rv := reflect.ValueOf(v)
Expand Down
Loading