Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove go.rice from Lotus #12806

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore: remove go.rice from Lotus #12806

wants to merge 3 commits into from

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jan 3, 2025

Related Issues

Closes: #6715

Proposed Changes

Removing go.rice completely from Lotus.

Checklist

Before you mark the PR ready for review, please make sure that:

rjan90 added 3 commits January 3, 2025 11:04
fix(lotus-fountain): remove go.rice dependency
build: remove go.rice from lotus-fountain target
chore: remove go.rice dependencies from go.mod
@rjan90 rjan90 requested a review from masih January 3, 2025 10:19
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Jan 3, 2025
@rjan90 rjan90 marked this pull request as ready for review January 3, 2025 10:48
masih
masih previously approved these changes Jan 3, 2025
Copy link
Collaborator

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe the changeset is that simple:

~$ FULLNODE_API_INFO=wss://api.chain.love ./lotus-fountain run 
2025-01-03T20:05:54.624+0100    INFO    main    lotus-fountain/main.go:35       Starting fountain
2025-01-03T20:05:54.624+0100    WARN    cliutil util/apiinfo.go:94      API Token not set and requested, capabilities might be limited.
2025-01-03T20:05:55.669+0100    INFO    main    lotus-fountain/main.go:110      Remote version: 1.30.0+mainnet+git.12e6428
2025-01-03T20:05:55.669+0100    ERROR   main    lotus-fountain/main.go:163      failed to parse funds template: open site/funds.html: no such file or directory
2025-01-03T20:05:55.669+0100    ERROR   main    lotus-fountain/main.go:181      failed to parse datacap template: open site/datacap.html: no such file or directory
Open http://127.0.0.1:7777

This is not enough: https://github.com/filecoin-project/lotus/pull/12806/files#diff-eb5becac460b911047484bb06a7c61019cc1efe1062005cb1367006e7bc2c10fR134

@masih masih dismissed their stale review January 5, 2025 13:26

@ribasushi is right (thanks Riba)

@rjan90 rjan90 marked this pull request as draft January 6, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ⌨️ In Progress
Development

Successfully merging this pull request may close these issues.

[BUG] Remove go.rice completely from lotus
3 participants