fix: Remove dart:io imports for analytics, auth and app check #16827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows these packages to be detected as wasm-compatible Packages: - firebase_analytics - firebase_app_check - firebase_auth
|
@russellwheatley @Lyokone – how should I handle versioning and changelogs here? |
russellwheatley
changed the title
russellwheatley
approved these changes
Dec 6, 2024
|
@kevmoo - you don't have to worry about versioning or changelogs, we use melos that handles it for us based on conventional commits. |
|
@russellwheatley – okay. Unlike the other ones, this shouldn't be breaking. I also don't think the e2e failure is related to this PR, but I'll let you land it. |
Lyokone
approved these changes
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows these packages to be detected as wasm-compatible
Packages: