Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getMarkerSchemaName special cases - look up marker schemas from data.type and nothing else #5293

Merged
merged 9 commits into from
Jan 22, 2025

Remove getMarkerSchemaName and the now-unused marker name argument fr…

8227268
Select commit
Loading
Failed to load commit list.
Merged

Remove getMarkerSchemaName special cases - look up marker schemas from data.type and nothing else #5293

Remove getMarkerSchemaName and the now-unused marker name argument fr…
8227268
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 22, 2025 in 0s

86.05% (-0.03%) compared to f07cfdc

View this Pull Request on Codecov

86.05% (-0.03%) compared to f07cfdc

Details

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.05%. Comparing base (f07cfdc) to head (8227268).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/processed-profile-versioning.js 76.19% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5293      +/-   ##
==========================================
- Coverage   86.07%   86.05%   -0.03%     
==========================================
  Files         311      311              
  Lines       29657    29666       +9     
  Branches     8196     8199       +3     
==========================================
+ Hits        25528    25529       +1     
- Misses       3547     3554       +7     
- Partials      582      583       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.