Skip to content

Commit

Permalink
[FCE-668] Fix Android icon and splash screen (#198)
Browse files Browse the repository at this point in the history
## Description

Replaces old icons with new ones to fix display issues on Android as
well to add support for theming and adds svg assets in case future edits
are needed.

## Motivation and Context

Android icons and splash screen were not displayed correctly.

## Types of changes

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to
      not work as expected)

## Checklist:

- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.

## Screenshots (if appropriate)
![Simulator Screenshot - iPhone 16 Pro Max - 2024-10-23 at 12 00
35](https://github.com/user-attachments/assets/535ab94a-b885-4124-b10f-8138304032ce)

![Screenshot_20241023_120029](https://github.com/user-attachments/assets/ff337b80-fb0d-49ec-a115-490824021b07)

![Screenshot_20241023_120009](https://github.com/user-attachments/assets/4140f765-07bd-468f-a6db-23f0e5235817)
  • Loading branch information
maksg authored Oct 29, 2024
1 parent bf54d4c commit 12d9ce0
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions examples/fishjam-chat/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"android": {
"adaptiveIcon": {
"foregroundImage": "./assets/adaptive-icon.png",
"monochromeImage": "./assets/adaptive-icon.png",
"backgroundColor": "#ffffff"
},
"package": "io.fishjam.example.fishjamchat",
Expand Down
Binary file modified examples/fishjam-chat/assets/adaptive-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions examples/fishjam-chat/assets/adaptive-icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/fishjam-chat/assets/icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions examples/fishjam-chat/assets/icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/fishjam-chat/assets/splash.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 12d9ce0

Please sign in to comment.