Fix thread issue

fishjam-cloud · Jan 7, 2025 · cfdb717 · cfdb717
1 parent e44e876
commit cfdb717
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/packages/ios-client/Sources/FishjamClient/media/Capturers/CameraCapturer.swift b/packages/ios-client/Sources/FishjamClient/media/Capturers/CameraCapturer.swift
@@ -29,14 +29,7 @@ class CameraCapturer: VideoCapturer {
     }
 
     public func stopCapture() {
-        // TODO: FCE-1012
-        // capturer.stopCapture() causes a crash so this is a temporary fix
-        // There are two things that don't work
-        // 1. Weird WebRTC SDK implementation that uses AVCaptureConnection in RTCCameraVideoCapturer
-        // 2. Retain cycle that does't allow this object to ever be dealocated.
-        DispatchQueue.main.async {
-            self.captureSession.stopRunning()
-        }
+        self.captureSession.stopRunning()
     }
 
     public func switchCamera() {

diff --git a/packages/react-native-client/ios/RNFishjamClientModule.swift b/packages/react-native-client/ios/RNFishjamClientModule.swift
@@ -124,7 +124,9 @@ public class RNFishjamClientModule: Module {
         }
 
         AsyncFunction("leaveRoom") {
-            rnFishjamClient.leaveRoom()
+            DispatchQueue.main.async {
+                rnFishjamClient.leaveRoom()
+            }
         }
 
         AsyncFunction("startCamera") { (config: CameraConfig) in