FCE-1023: Change how prepareCamera works #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,9 +69,7 @@ | |||
| } | |||
| } | |||
| ], | |||
| [ | |||
| "./plugin/build/with-local-paths-for-native-packages.js" // Only relevant for local development of packages/ios-client and packages/android-client | |||
There was a problem hiding this comment.
note: Removed those comments as the current version of expo prebuild removes it by default.
mironiasty
approved these changes
Jan 14, 2025
examples/fishjam-chat/app.json
Outdated
| }, | ||
| "NSCameraUsageDescription": "We need to access your camera for video calls.", | ||
| "NSMicrophoneUsageDescription": "We need to access your microphone so you can talk during calls.", | ||
| "ITSAppUsesNonExemptEncryption": false | ||
| } | ||
| }, | ||
| "appleTeamId": "J5FM626PE2" |
There was a problem hiding this comment.
Is this ok to keep it here? 🤔
There was a problem hiding this comment.
At first I thought it was a good idea, because then we won't have to select a team everytime, but then I realised that this is a public example 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prepareCamerawas called multiple timesMotivation and Context
How has this been tested?
Types of changes
not work as expected)
Checklist: