add try_ functions for slices and str
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
reviewed
Jan 22, 2025
src/lib.rs
Outdated
| { | ||
| let layout = Layout::for_value(src); | ||
| let dst = self.try_alloc_layout(layout)?.cast::<T>(); | ||
| let result = unsafe { slice::from_raw_parts_mut(dst.as_ptr(), src.len()) }; |
There was a problem hiding this comment.
I don't think this is safe because it is creating a reference of potentially uninitialized data. I think this needs to use std::ptr::copy_nonoverlapping instead.
There was a problem hiding this comment.
Thank you, good point. core::ptr::copy_nonoverlapping for the no_std case.
Co-authored-by: Nick Fitzgerald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's good to be able to deal with allocation errors explicitly.