Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added retry budget and some refactoring. #609

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

Dmitrykob
Copy link
Contributor

@Dmitrykob Dmitrykob commented Apr 9, 2024

Overview

The changes are described and tested in the context of deckhouse PR

What this PR does / why we need it

Add repeated queries to get CRD and apply conversion strategies.

Special notes for your reviewer

Tag version upgrade is required.

The occasion with the use of watch has been tried. It doesn't work. Because for a successful subscription - CRD must also already be installed in the cluster.

@Dmitrykob Dmitrykob self-assigned this Apr 9, 2024
@Dmitrykob Dmitrykob added the dependencies Pull requests that update a dependency file label Apr 9, 2024
@Dmitrykob Dmitrykob modified the milestones: 1.4, 1.4.7 Apr 9, 2024
@Dmitrykob Dmitrykob marked this pull request as ready for review April 9, 2024 08:52
@Dmitrykob Dmitrykob requested a review from yalosev April 9, 2024 10:23
Signed-off-by: dmitry.koba <[email protected]>
@Dmitrykob Dmitrykob requested a review from yalosev April 10, 2024 12:12
@yalosev yalosev merged commit d4ef439 into main Apr 11, 2024
8 checks passed
@yalosev yalosev deleted the retry-budget-and-refactoring branch April 11, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants