Add blocklist struct #325
Add blocklist struct #325
Conversation
ferranbt
requested review from
dvush,
ZanCorDX and
liamaharon
as code owners
Benchmark results for
|
| Date (UTC) | 2025-01-06T08:43:09+00:00 |
| Commit | 81ccfc0be832d395899feaef7fe4b137958cc929 |
| Base SHA | 026df71fdf2c8c6f6740682b6358d02f0e14bc09 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| cloning_3000_branch_node_size_elements | -2.08% | Performance has improved. |
| gather_nodes_shared_cache | 2.48% | Performance has degraded. |
| gather_nodes_storage_tries | 2.22% | Performance has degraded. |
| MEV-Boost SubmitBlock serialization/JSON encoding | -36.51% | Performance has improved. |
| gather_nodes_empty_account | 2.74% | Performance has degraded. |
crates/rbuilder/src/blocklist/mod.rs
Outdated
| pub fn len(&self) -> usize { | ||
| self.list.len() | ||
| } | ||
|
|
||
| pub fn contains(&self, address: &Address) -> bool { | ||
| self.list.contains(address) | ||
| } |
There was a problem hiding this comment.
Might want to impl
impl Deref for BlockList {
type Target = HashSet<Address>;
fn deref(&self) -> &Self::Target {
&self.list
}
}instead of the inner methods individually
There was a problem hiding this comment.
Added Deref but not sure what changes I have to make to the len and contains functions.
There was a problem hiding this comment.
You can remove them now :)
crates/rbuilder/src/blocklist/mod.rs
Outdated
| fn from(path: PathBuf) -> Self { | ||
| Self::from_file(path).unwrap_or_else(|_| Self::new()) | ||
| } |
There was a problem hiding this comment.
I would expect this type of method to return an error if the path doesn't exist instead of an empty list.
| fn from(path: PathBuf) -> Self { | |
| Self::from_file(path).unwrap_or_else(|_| Self::new()) | |
| } | |
| fn try_from(path: PathBuf) -> Result<Self, ...> { | |
| Self::from_file(path).unwrap_or_else(|_| Self::new()) | |
| } |
There are three benefits for this abstraction:
|
|
Not sure if it's needed right now, but it's done and might be useful in the future. |
📝 Summary
This PR replaces raw
HashSet<Address>usages throughout the codebase with a dedicated BlockList struct that encapsulates the blocklist functionality in a single location. The struct implements a custom deserialize operation that maintains backward compatibility: if a blocklist file exists it parses the addresses, otherwise it falls back to an empty blocklist. This behavior is fully unit tested.✅ I have completed the following steps:
make lintmake test