Backtest build block app for synthetic blocks. #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanCorDX
requested review from
dvush,
ferranbt,
liamaharon and
metachris
as code owners
Benchmark results for
|
| Date (UTC) | 2025-01-06T21:53:10+00:00 |
| Commit | 11311e851230a8f8e7723c21881ab1ae4baad37c |
| Base SHA | 06840a87a5330a776f1566f7831b406738616b96 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| gather_nodes_big_changes_account | 2.05% | Performance has degraded. |
| MEV-Boost SubmitBlock serialization/JSON encoding | 3.64% | Performance has degraded. |
## 📝 Summary - Removes a `redact-sensitive` check following #332 - Scales up the CI runners to solve OOM issue https://github.com/flashbots/rbuilder/actions/runs/12640958168?pr=344
dvush
approved these changes
Jan 14, 2025
sukoneck
pushed a commit
that referenced
this pull request
Jan 15, 2025
## 📝 Summary For some reason github allowed to merge #344 with errors! Fixed those errors and also disabled roothash calculation on backtesting. ## 💡 Motivation and Context I was threatened by the the other programmers. ## ✅ I have completed the following steps: * [X] Run `make lint` * [X] Run `make test` * [ ] Added tests (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR makes backtest-build-block more versatile so the chain used and orders come from an
OrdersSourceinstead of the hardcoded mainnet we had.The original backtest_build_block behavior is now achieved using the
OrdersSourceLandedBlockFromDBOrdersSource.A new
OrdersSourceSyntheticOrdersSourceis provided as an example of how to run backtest-build-block with a syntetic chain and synthetic orders.💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test