Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add builder tx to new op-rbuilder #361

Merged
merged 20 commits into from
Jan 22, 2025
Merged

add builder tx to new op-rbuilder #361

merged 20 commits into from
Jan 22, 2025
+1,171 −34

Conversation

avalonche
Copy link
Contributor

📝 Summary

💡 Motivation and Context

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

ferranbt
ferranbt requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ferranbt ferranbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Benchmark results for 5a3ced8

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/5a3ced8-2182f96/report/index.html
Date (UTC) 2025-01-22T19:36:57+00:00
Commit 5a3ced818cbebcb1ee2b60c6305278ede07189cc
Base SHA 2182f960c4dd21024e292aa9d28ab110b52d8636

Significant changes

None

Base automatically changed from ferranbt/feature-x to develop January 16, 2025 15:01
@avalonche avalonche force-pushed the op-rbuilder/builder-tx branch from 70642cf to 0fc1481 Compare January 17, 2025 21:08
ferranbt
ferranbt reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ferranbt ferranbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the builder changes necessary now?

@avalonche avalonche marked this pull request as ready for review January 17, 2025 22:26
ZanCorDX
ZanCorDX requested changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@ZanCorDX ZanCorDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that you copy/pasted tx_signer.rs.
Why?
Unless imposible please correct it.

@avalonche
Copy link
Contributor Author

@ZanCorDX see #361 (comment)

@avalonche avalonche force-pushed the op-rbuilder/builder-tx branch from 97f27b6 to 0fc1481 Compare January 22, 2025 17:36
@ferranbt ferranbt self-requested a review January 22, 2025 19:44
@avalonche avalonche merged commit 3d00697 into develop Jan 22, 2025
4 checks passed
@avalonche avalonche deleted the op-rbuilder/builder-tx branch January 22, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanCorDX ZanCorDX ZanCorDX approved these changes

@ferranbt ferranbt ferranbt approved these changes

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@liamaharon liamaharon Awaiting requested review from liamaharon liamaharon is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avalonche @ferranbt @ZanCorDX