-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Librashader support #43
base: master
Are you sure you want to change the base?
Conversation
Started test build 144418 |
Build 144418 successful
|
Is this ever going to be merged? |
Well it doesn't work. It compiles and downloads librashader to the correct folder as far as I understand, but ares doesn't seem to correctly pick it up. I created this PR to cover most of the grunt work in hopes someone could figure out the last piece. |
Started test build 152553 |
Build 152553 successful
|
Just tried the last flatpak test build and it seems to work for me. |
You're right, sorry about that. It wasn't working for whatever reason when I initially opened this, but probably user error. @ghisvail this PR is ready for review/ready for merging, everything seems to be working and tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for spending time and efforts to enable this feature. I left a few comments to address before merging.
Cheers
Started test build 153309 |
Build 153309 failed |
Started test build 153313 |
Build 153313 failed |
* Folder created by Flatpak Builder
Started test build 159218 |
Build 159218 failed |
bot, build |
Queued test build for dev.ares.ares. |
Started test build 159758 |
Build 159758 successful
|
@ghisvail this PR should be good to go now :) |
Started test build 159769 |
Build 159769 successful
|
Hi. I wanted to test this librashader fix for ares on my Steam Deck, but the build links are giving me a 404. Is there anyway I could get another one to try it out? :) |
bot, build |
Queued test build for dev.ares.ares. |
Started test build 167399 |
Build 167399 successful
|
This PR adds Librashader support.
Closes #36
Supercedes: #39
Sorry, recreating this PR on a new account, was having some account issues.