Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Librashader support #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BlueInterlude
Copy link

@BlueInterlude BlueInterlude commented Sep 4, 2024

This PR adds Librashader support.

Closes #36

Supercedes: #39

Sorry, recreating this PR on a new account, was having some account issues.

@flathubbot
Copy link
Contributor

Started test build 144418

@flathubbot
Copy link
Contributor

Build 144418 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127493/dev.ares.ares.flatpakref

@thydungeonman
Copy link

Is this ever going to be merged?

@BlueInterlude
Copy link
Author

Is this ever going to be merged?

Well it doesn't work. It compiles and downloads librashader to the correct folder as far as I understand, but ares doesn't seem to correctly pick it up. I created this PR to cover most of the grunt work in hopes someone could figure out the last piece.

@flathubbot
Copy link
Contributor

Started test build 152553

@flathubbot
Copy link
Contributor

Build 152553 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/135640/dev.ares.ares.flatpakref

@thydungeonman
Copy link

Just tried the last flatpak test build and it seems to work for me.

@BlueInterlude
Copy link
Author

Just tried the last flatpak test build and it seems to work for me.

You're right, sorry about that. It wasn't working for whatever reason when I initially opened this, but probably user error.

@ghisvail this PR is ready for review/ready for merging, everything seems to be working and tested.

Copy link
Collaborator

@ghisvail ghisvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for spending time and efforts to enable this feature. I left a few comments to address before merging.

Cheers

.gitignore Outdated Show resolved Hide resolved
dev.ares.ares.yaml Outdated Show resolved Hide resolved
dev.ares.ares.yaml Outdated Show resolved Hide resolved
@BlueInterlude BlueInterlude marked this pull request as draft October 10, 2024 17:14
@flathubbot
Copy link
Contributor

Started test build 153309

@flathubbot
Copy link
Contributor

Build 153309 failed

@flathubbot
Copy link
Contributor

Started test build 153313

@flathubbot
Copy link
Contributor

Build 153313 failed

@ghisvail ghisvail marked this pull request as ready for review October 12, 2024 16:40
@flathubbot
Copy link
Contributor

Started test build 159218

@flathubbot
Copy link
Contributor

Build 159218 failed

@BlueInterlude
Copy link
Author

bot, build

@flathubbot
Copy link
Contributor

Queued test build for dev.ares.ares.

@flathubbot
Copy link
Contributor

Started test build 159758

@flathubbot
Copy link
Contributor

Build 159758 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/142839/dev.ares.ares.flatpakref

@BlueInterlude
Copy link
Author

@ghisvail this PR should be good to go now :)

@flathubbot
Copy link
Contributor

Started test build 159769

@flathubbot
Copy link
Contributor

Build 159769 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/142850/dev.ares.ares.flatpakref

@ann3nova
Copy link

Hi. I wanted to test this librashader fix for ares on my Steam Deck, but the build links are giving me a 404. Is there anyway I could get another one to try it out? :)

@BlueInterlude
Copy link
Author

bot, build

@flathubbot
Copy link
Contributor

Queued test build for dev.ares.ares.

@flathubbot
Copy link
Contributor

Started test build 167399

@flathubbot
Copy link
Contributor

Build 167399 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/150495/dev.ares.ares.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing librashader
5 participants