Skip to content

Commit

Permalink
Update community pull request process (#25356)
Browse files Browse the repository at this point in the history
  • Loading branch information
noahtalerman authored Jan 10, 2025
1 parent 0e914f8 commit fedf38b
Showing 1 changed file with 4 additions and 16 deletions.
20 changes: 4 additions & 16 deletions handbook/engineering/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,24 +220,12 @@ In these cases there are two differences in our process:

If you're assigned a community pull request for review, it is important to keep things moving for the contributor. The goal is to not go more than one business day without following up with the contributor.

A PR should be merged if:
If the PR is a quick fix (i.e. typo) or obvious technical improvement that doesn't change the product, it can be merged.

- It's a change that is needed and useful.
- The CI is passing.
- Tests are in place.
- Documentation is updated.
- Changes file is created.
For PRs that change the product:

For PRs that aren't ready to merge:

- Thank the contributor for their hard work and explain why we can't merge the changes yet.
- Encourage the contributor to reach out in the #fleet channel of osquery Slack to get help from the rest of the community.
- Offer code review and coaching to help get the PR ready to go (see note below).
- Keep an eye out for any updates or responses.

> Sometimes (typically for Fleet customers), a Fleet team member may add tests and make any necessary changes to merge the PR.
If everything is good to go, approve the review.
- Set the PR to draft.
- Thank the contributor for their hard work, explain that all changes to the product go through Fleet's [prioritization process]([TODO link](https://fleetdm.com/handbook/company/product-groups#how-feature-requests-are-prioritized)), and ask them to file a [feature request]([TODO link here](https://github.com/fleetdm/fleet/issues/new?assignees=&labels=%3Aproduct&projects=&template=feature-request.md&title=)).

For PRs that will not be merged:

Expand Down

0 comments on commit fedf38b

Please sign in to comment.