Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry.yml #19713

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Update registry.yml #19713

merged 5 commits into from
Jun 19, 2024

Conversation

nonpunctual
Copy link
Contributor

minify long query. see if it does any better. Is it possible to add explicit line breaks where I want them? thanks.

minify long query. see if it does any better. Is it possible to add explicit line breaks where I want them? thanks.
@eashaw
Copy link
Contributor

eashaw commented Jun 13, 2024

@nonpunctual This is what this change looks like:
Current version:
image

With this change:
image

@nonpunctual
Copy link
Contributor Author

nonpunctual commented Jun 13, 2024

@eashaw Can explicit line breaks be added?

@eashaw
Copy link
Contributor

eashaw commented Jun 14, 2024

@nonpunctual Not currently (you can add them, but a CSS rule will override them).
IIRC, we are doing that to make the examples that used different YAML block scalars look consistent on table pages. Now that we're only using one block scalar, we should be able to remove that CSS rule and allow for explicit line breaks.

@nonpunctual
Copy link
Contributor Author

@eashaw ok. I am afraid that may be breaking change for you but if you're comfortable with it, it would be nice to try on this one especially. It can definitely be copied & pasted & it works but I feel like the utility of the queries is diminished if they are posted in a readable way & this means people might mess with them after copying them which will likely lead to typos.

@nonpunctual
Copy link
Contributor Author

@eashaw what needs to happen to test removing the CSS rule mentioned above? Thanks.

@eashaw
Copy link
Contributor

eashaw commented Jun 18, 2024

@nonpunctual I added what is required for this to #19750.

@eashaw
Copy link
Contributor

eashaw commented Jun 19, 2024

@nonpunctual The tables pages have been updated to allow explicit newlines in example queries. Can you close this PR if it is no longer needed?

Added 2nd query in with line breaks. Added 2 space indent to each line (hope that's the right move...) Sorry for the delay!
@nonpunctual nonpunctual merged commit 60b3765 into main Jun 19, 2024
2 checks passed
@nonpunctual nonpunctual deleted the nonpunctual-patch-7 branch June 19, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants