Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Update software empty states #19744

Merged
merged 8 commits into from
Jun 17, 2024
Merged

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Jun 13, 2024

Issue

Cerra #19181

Description

  • Update software empty states on Software tab main listed pages
    • Includes fix to hide count/search bar if there's no software detected on main software page
  • Update software empty states on Host details page
    • Includes fix to hide count/search bar if there's no software detected

Other

  • Remove all sandbox references in software code

Screenrecording

Empty search states screenrecording
https://www.loom.com/share/ed0150e07eea40a787d5d84817dea42b?sid=1e4c3903-b5fd-408f-9cf5-8a88eecd468a

No software detected (initial empty states) screenrecording
https://www.loom.com/share/c8cec03dc63b4d21a054ef1a129a2076?sid=81ab429f-de19-4e85-a18d-9883e7fde109

No software detected (initial empty state) of a host's software screenshot
Screenshot 2024-06-14 at 10 27 53 AM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia marked this pull request as ready for review June 14, 2024 15:43
@RachelElysia RachelElysia requested a review from a team as a code owner June 14, 2024 15:43
@jacobshandling
Copy link
Contributor

👀

jacobshandling
jacobshandling previously approved these changes Jun 14, 2024
Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!

@@ -10,32 +10,46 @@ import { ISoftwareDropdownFilterVal } from "pages/SoftwarePage/SoftwareTitles/So

export interface IEmptySoftwareTableProps {
softwareFilter?: ISoftwareDropdownFilterVal;
/** tableName is displayed in the search empty state */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@RachelElysia RachelElysia merged commit 85a5c6e into main Jun 17, 2024
9 checks passed
@RachelElysia RachelElysia deleted the software-empty-states branch June 17, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants