Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep all fleetd-base and fleetd-chrome artifacts. #19749

Merged
merged 31 commits into from
Jun 17, 2024
Merged

Keep all fleetd-base and fleetd-chrome artifacts. #19749

merged 31 commits into from
Jun 17, 2024

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Jun 13, 2024 •
edited
Loading

#19182 and #19111

  • Upload and keep all fleetd-base and fleetd-chrome artifacts
  • Code sign fleetd-base.msi
  • Verify checksums and try installing fleetd-base packages

These changes will apply the fleet-base workflow to download-testing.fleetdm.com, and another PR will change to the production endpoint (download.fleetdm.com) after QA.

fleetd-base

Successful fleetd-base workflow run: https://github.com/fleetdm/fleet/actions/runs/9522282299

New meta files will be in the stable directory:

The files in the root directory will no longer be updated for backward compatibility.

fleetd-chrome

Successful fleetd-chrome beta run: https://github.com/fleetdm/fleet/actions/runs/9552391075/job/26328861033

@getvictor getvictor force-pushed the victor/19182-store-artifacts branch from 1910c94 to 5a2ecb5 Compare June 17, 2024 17:53
@getvictor getvictor changed the title Keep all fleetd-base artifacts. Keep all fleetd-base and fleetd-chrome artifacts. Jun 17, 2024
@getvictor getvictor marked this pull request as ready for review June 17, 2024 18:08
@georgekarrv
Copy link
Member

@roperzh @mna ^

mna
mna previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@mna mna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the most well-versed in Github workflows but that looks good to me!

sharon-fdm
sharon-fdm approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@sharon-fdm sharon-fdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a guided tour with Victor.
LGTM.

@getvictor getvictor merged commit d3b9bad into main Jun 17, 2024
4 checks passed
@getvictor getvictor deleted the victor/19182-store-artifacts branch June 17, 2024 20:49
@getvictor getvictor mentioned this pull request Jun 17, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharon-fdm sharon-fdm sharon-fdm approved these changes

@mna mna mna left review comments

@lukeheath lukeheath Awaiting requested review from lukeheath lukeheath is a code owner

@georgekarrv georgekarrv Awaiting requested review from georgekarrv georgekarrv is a code owner

Assignees

@sharon-fdm sharon-fdm

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@getvictor @georgekarrv @mna @sharon-fdm