fix: use a new strategy for finding the app name in case the title is wrong #25297
Conversation
| // try to get the name some other way. | ||
| var knownBadNames = map[string]struct{}{ | ||
| "DISTRIBUTION_TITLE": {}, | ||
| "MacFULL": {}, |
There was a problem hiding this comment.
MacFULL and SU_TITLE are two other "bad names" that @jmwatts found, as we find more we can add them to this set.
There was a problem hiding this comment.
Guessing this fix worked on the other packages @jmwatts found? Or do some of those wind up needing to fall all the way back to bundle ID?
| // try to get the name some other way. | ||
| var knownBadNames = map[string]struct{}{ | ||
| "DISTRIBUTION_TITLE": {}, | ||
| "MacFULL": {}, |
There was a problem hiding this comment.
Guessing this fix worked on the other packages @jmwatts found? Or do some of those wind up needing to fall all the way back to bundle ID?
Co-authored-by: Ian Littman <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25297 +/- ##
==========================================
+ Coverage 63.54% 63.55% +0.01%
==========================================
Files 1618 1618
Lines 154433 154459 +26
Branches 4037 4037
==========================================
+ Hits 98132 98174 +42
+ Misses 48562 48551 -11
+ Partials 7739 7734 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 073d0bc.
|
tests are busted due to an unrelated issue, but I will re-trigger once that is addressed just to be sure. |
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.