#23235 API docs: Add certificates to host vitals for macOS, iOS, iPadOS #25317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleet-release
approved these changes
Jan 9, 2025
rachaelshaw
commented
Jan 9, 2025
Comment on lines
+2760
to
+2785
| "certificates": [ // Available for macOS/iOS/iPadOS hosts | ||
| { | ||
| "id": 3, | ||
| "not_valid_after": "2021-08-19T02:02:17Z", | ||
| "not_valid_before": "2021-08-19T02:02:17Z", | ||
| "certificate_authority": true, | ||
| "common_name": "FleetDM", | ||
| "key_algorithm": "rsaEncryption", | ||
| "key_strength": 2048, | ||
| "key_usage": "CRL Sign, Key Cert Sign", | ||
| "serial": 1, | ||
| "signing_algorithm": "sha256WithRSAEncryption", | ||
| "subject": { | ||
| "country": "US", | ||
| "organization": "Fleet Device Management Inc.", | ||
| "organizational_unit": "Fleet Device Management Inc.", | ||
| "common_name": "FleetDM" | ||
| }, | ||
| "issuer": { | ||
| "country": "US", | ||
| "organization": "Fleet Device Management Inc.", | ||
| "organizational_unit": "Fleet Device Management Inc.", | ||
| "common_name": "FleetDM" | ||
| }, | ||
| } | ||
| ], |
There was a problem hiding this comment.
Dev note:
Omitted from response if platform is not macOS, iOS, or iPadOS.
rachaelshaw
commented
Jan 9, 2025
Comment on lines
+3231
to
+3256
| "certificates": [ // Available for macOS/iOS/iPadOS hosts | ||
| { | ||
| "id": 3, | ||
| "not_valid_after": "2021-08-19T02:02:17Z", | ||
| "not_valid_before": "2021-08-19T02:02:17Z", | ||
| "certificate_authority": true, | ||
| "common_name": "FleetDM", | ||
| "key_algorithm": "rsaEncryption", | ||
| "key_strength": 2048, | ||
| "key_usage": "CRL Sign, Key Cert Sign", | ||
| "serial": 1, | ||
| "signing_algorithm": "sha256WithRSAEncryption", | ||
| "subject": { | ||
| "country": "US", | ||
| "organization": "Fleet Device Management Inc.", | ||
| "organizational_unit": "Fleet Device Management Inc.", | ||
| "common_name": "FleetDM" | ||
| }, | ||
| "issuer": { | ||
| "country": "US", | ||
| "organization": "Fleet Device Management Inc.", | ||
| "organizational_unit": "Fleet Device Management Inc.", | ||
| "common_name": "FleetDM" | ||
| }, | ||
| } | ||
| ], |
There was a problem hiding this comment.
Dev note:
Omitted from response if platform is not macOS, iOS, or iPadOS.
rachaelshaw
changed the title
fleet-release
approved these changes
Jan 9, 2025
rachaelshaw
added
the
~api-or-yaml-design
fleet-release
approved these changes
Jan 9, 2025
15 tasks
rachaelshaw
commented
Jan 10, 2025
Comment on lines
+2772
to
+2783
| "subject": { | ||
| "country": "US", | ||
| "organization": "Fleet Device Management Inc.", | ||
| "organizational_unit": "Fleet Device Management Inc.", | ||
| "common_name": "FleetDM" | ||
| }, | ||
| "issuer": { | ||
| "country": "US", | ||
| "organization": "Fleet Device Management Inc.", | ||
| "organizational_unit": "Fleet Device Management Inc.", | ||
| "common_name": "FleetDM" | ||
| }, |
There was a problem hiding this comment.
Dev note:
subject and issuer data from osquery looks like this:
/C=US/O=Fleet Device Management Inc./OU=Fleet Device Management Inc./CN=FleetDM
C→ country
O→organization
OU→ organizational_unit
CN→ common_name
There was a problem hiding this comment.
With the number of potential certs on a device I don't think we should stuff all of this into host details.
My recommendation is that we have the list with total count and the first 5 name expiry and id.
Then a separate paginated response for full cert details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #23235
Add
certificatesto "Get host" and "Get host by device token" endpoints.This list will be available for macOS, iOS, and iPadOS hosts. It will be omitted for other platforms.