Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow software installers with unknown versions through rather than failing the upload #25426

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Jan 14, 2025

For #25201.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

@iansltx
Copy link
Member Author

iansltx commented Jan 14, 2025

This is in draft pending a product decision on whether this is how we solve #25201, where the EXE provided has no version information at all.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (ca15cbe) to head (8b2c283).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25426   +/-   ##
=======================================
  Coverage   63.58%   63.59%           
=======================================
  Files        1619     1619           
  Lines      154939   154936    -3     
  Branches     4038     4038           
=======================================
  Hits        98524    98524           
+ Misses      48646    48644    -2     
+ Partials     7769     7768    -1     
Flag Coverage Δ
backend 64.43% <100.00%> (+<0.01%) ⬆️
frontend 53.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant