Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hiding secrets guide #25439

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update hiding secrets guide #25439

wants to merge 7 commits into from
+89 −135

Conversation

noahtalerman
Copy link
Member

Update guide to be more explicit: this feature is to hide secrets in profiles in scripts.

Changes:

  • Rename guide
  • Remove section about UI and API. Hiding secrets is YAML (GitOps) only for now. The API endpoints to add secrets are contributor endpoints (not for API users)

Check out the comments here to understand the current confusion:

@noahtalerman noahtalerman removed the request for review from Drew-P-drawers January 14, 2025 22:38
@noahtalerman
Copy link
Member Author

FYI @getvictor I updated your guide here. Your pass was great. Just clarifying the best practice and language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenhouchins allenhouchins Awaiting requested review from allenhouchins

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@noahtalerman